zkxvh

Results 11 comments of zkxvh

Hi @basilevs. Just FYI, I checked this PR with [this snippets](https://github.com/eclipse-platform/eclipse.platform.swt/pull/1743#issuecomment-2604085464) and (at least on my machine) this PR has no negative effects on how images gets rendered in the...

### Fix for #678 This is the 1st commit in this branch. Reproducing the crash: - https://github.com/eclipse-platform/eclipse.platform.swt/issues/678#issue-1715955828 - https://github.com/eclipse-platform/eclipse.platform.swt/pull/1611/ - https://github.com/eclipse-platform/eclipse.platform.swt/issues/678#issuecomment-2507994360 The cause of the crash is described here: https://github.com/eclipse-platform/eclipse.platform.swt/issues/678#issuecomment-2511711696...

### Fix for #1739 This is the 2nd and 3rd commits in this branch. The 2nd commit adds native method `gtk_tree_view_column_queue_resize(...)` from GTK. I'm not sure whether something else should...

> There is one test failing: > > ``` > java.lang.AssertionError: SetData callback count not in range: 10001 > at org.junit.Assert.fail(Assert.java:89) > at org.junit.Assert.assertTrue(Assert.java:42) > at org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Tree.test_Virtual(Test_org_eclipse_swt_widgets_Tree.java:966) > ``` >...

`Test_org_eclipse_swt_widgets_Tree.test_Virtual()` is fixed in commit 62b1a13. The problem was in `setScrollWidth()` which is invoked at the end of `cellDataProc(...)`. As I understand, `setScrollWidth()` works when `Tree.getColumnCount()==0`, i.e. when the default...

Hi @deepika-u You've checked that the fix for #1739 works. Could you please also check if the fix for #678 works on your machine? For that please run snippet [Issue678_JvmCrashOnTreeItemSetImage.java](https://github.com/eclipse-platform/eclipse.platform.swt/pull/1743/files#diff-f4a80adf4e4f2b561d703bc8d4d79ab1f163c3acd17cbe8bdcf1195fca3a2b82)....

I'm sorry for the delayed response too. Thank you for checking this PR. The errors in the console output is another way how the bug can show itself. Basically the...

> @zkxvh : this branch has merge conflicts with master. Could you please rebase the changes on latest master state? OK. I will rebase the changes and check again that...

> Also note, you are not supposed to check-in so files! OK. I'll remove *.so from the changes when I'll make the rebase. BTW I saw in the history that...

Hi, @iloveeclipse I rebased the changes to the latest master + removed *.so from the PR. I also checked that everything works again - just like I did [here](https://github.com/eclipse-platform/eclipse.platform.swt/pull/1743#issuecomment-2604085464). BTW,...