Zhian N. Kamvar

The guidelines for the 2015-2016 thesis say that chapter titles should be single-spaced.

parse_date is succeptible to the 2038 bug

1

I originally thought this was because Linus hated the future, but I see that It was because of an integer overflow. ``` r # Last known day to work parsedate::parse_date("01/19/2038...

Update website

6

The website for epicontacts is sorely out-of-date. For example, the CRAN version has `edges_pal()` included in the documentation for colors, but it is missing on the website: http://www.repidemicsconsortium.org/epicontacts/reference/colors.html It becomes...

create pathological data set

1

- NAs in all columns - missing ids in linelist - missing ids in contacts - clusters of known sizes - degrees of known sizes - unconnected cases - node...

Code review of epicontacts

7

This is based on the rOpenSci code reviews: https://devguide.ropensci.org/ @zkamvar and @finlaycampbell are assigned.

refactor tests that rely on saved data

1

There are currently a lot of tests that rely on saved data structures. These are inherently fragile and should be thoroughly tested before any other changes are made to the...

Is it necessary to have dplyr as a dependency?

2

I did a search for dplyr in this repo and found this: https://github.com/reconhub/epicontacts/search?q=dplyr&type=Code Basically, dplyr is only used for joins right now and I'm wondering if it may be better...

I noticed that the test for print.epicontacts (https://github.com/reconhub/epicontacts/blob/73e0c9a943d42e0b13b1a624f784bef6e432333a/tests/testthat/test_print.epicontacts.R) is the only one that does not run on Travis. It fails on my machine, which means that the print functionality was...

XML: add NODE_FOOTNOTE type strings and footnote emitters

1

I believe this will begin to address the issues in https://github.com/github/cmark-gfm/issues/341 and https://github.com/github/cmark-gfm/issues/316. (Update 2023-04-17: I added `id` and `destination` attributes to these nodes based on what I saw in...

gert and git do not agree on what order to read the config

1

It looks like {gert} prioritizes config items from top to bottom, but command line git prioritizes bottom to top in the case of duplicate keys. I have a situation where...