zirain

Results 327 comments of zirain

通常来说你需要将MR提交给master分支,如果有需要的话,审核人会加上cherry-pick标签,cherry-pick到指定的版本 带有如下标记的页面通常包含有对应的测试脚本保证文档的正确性 ![image](https://user-images.githubusercontent.com/4354057/172754544-c5875150-2bd4-4e27-b4aa-704c698c8240.png) 在修改markdown内容后,你需要本地运行 `make gen && make lint`,如果可以的话,保证修改后测试用例通过。 比如本地运行 `TEST_ENV=kind ADDITIONAL_CONTAINER_OPTIONS="--network host" make doc.test.profile_none` 确认是否有错误。

see https://preliminary.istio.io/latest/docs/setup/additional-setup/sidecar-injection/#controlling-the-injection-policy

preview is here https://deploy-preview-11683--preliminary-istio.netlify.app/ ![image](https://user-images.githubusercontent.com/4354057/183013642-7cf910f9-0527-4fe5-8872-525d8fc6582d.png)

/test doc.test.profile_default_istio.io

@kezhenxu94 can you add doc test for this? like zipkin https://github.com/istio/istio.io/tree/master/content/en/docs/tasks/observability/distributed-tracing/zipkin [here](https://github.com/istio/istio.io/blob/master/README.md#testing-document-content) is the guide doc.

> @kezhenxu94: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests: > > Test name Commit Details Required Rerun command...