Chris Ziogas

Results 150 comments of Chris Ziogas

@velikanov please let me know if you find some time to test this

Thanks for the help @jrmsklar. This PR is partially handled in #27. Current PR is not backward compatible as it also changes `maximumInccorectPasscodeAttempts` which is a public property and it...

> Will maximumInccorectPasscodeAttempts be updated in that other PR? no, it won't. @velikanov has a nice list with such typos #9. I was thinking that we should wait for the...

A temporary hack that you can use is to use `.RemovePasscode` which doesn't have any added functionality at the moment. This will help your team on keep using this repo...

Nope. And I am not sure who can decide this. It will be nice if we can form a group of maintainers and then have a call about it. Currently...

I am suggesting this and I am willing myself to be a volunteer, but I can't take the lead as it is @yankodimitrov project. If @yankodimitrov agrees then we can...

Very nice @bill350. What if you add a `PasscodeLockConfigurationType` extension for setting the default values for backward combatibility? ``` public protocol PasscodeLockConfigurationType { var repository: PasscodeRepositoryType {get} var passcodeLength: Int...

Can you @bill350 add the default implementation before I can test this? Thanks

Thanks @bill350, will try to check it as soon as possible.

Hi @bill350, sorry for taking me so long to test it. I am migrating the code for Swift 4 and I gave a test to your branch too. The code...