SwiftPasscodeLock icon indicating copy to clipboard operation
SwiftPasscodeLock copied to clipboard

Published 20 hours ago • verified publisher icon velikanov

Fix small typo

Open jrmsklar opened this issue 8 years ago • 4 comments

This PR fixes a small typo in the word "incorrect".

jrmsklar avatar Jun 15 '16 15:06 jrmsklar

Thanks for the help @jrmsklar.

This PR is partially handled in #27.

Current PR is not backward compatible as it also changes maximumInccorectPasscodeAttempts which is a public property and it might brake current apps using this lib.

ziogaschr avatar Jun 15 '16 16:06 ziogaschr

@ziogaschr gotchya 👍.

Will maximumInccorectPasscodeAttempts be updated in that other PR? I think it'd be beneficial to correct that even at the expense of developers updating that name when updating the pod.

jrmsklar avatar Jun 15 '16 16:06 jrmsklar

Will maximumInccorectPasscodeAttempts be updated in that other PR?

no, it won't.

@velikanov has a nice list with such typos #9.

I was thinking that we should wait for the next release, let's see what rest people think.

ziogaschr avatar Jun 15 '16 16:06 ziogaschr

Sounds good.

jrmsklar avatar Jun 15 '16 16:06 jrmsklar