custom modifier register conflict
if registering a modifier that has the same name as modifier in config, only the new modifier will be loaded
for this to work, the schema has to be updated with the default values as well. This could happen here https://github.com/zincware/ZnDraw/blob/2a248c5f4fb1d7c5ccebc5a491cd3fa0f745b411/zndraw/zndraw.py#L446-L460
and was implemented like this until it was removed by accident, because it wasn't tested properly https://github.com/zincware/ZnDraw/blob/5dd4fed9904e36b646a67297c9dc90eeadf4e540/zndraw/app.py#L91-L94
Codecov Report
Attention: 10 lines in your changes are missing coverage. Please review.
Comparison is base (
d160a00) 57.78% compared to head (a06e5a7) 57.79%.
| Files | Patch % | Lines |
|---|---|---|
| zndraw/zndraw.py | 60.00% | 8 Missing :warning: |
| zndraw/settings.py | 50.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 57.78% 57.79%
=======================================
Files 18 18
Lines 1606 1630 +24
=======================================
+ Hits 928 942 +14
- Misses 678 688 +10
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.