Jonas Chevalier
Jonas Chevalier
So if somebody is interested in this, go for it :)
Yes, that could work I suppose. The only way to know for sure is to implement and try it out for a while.
Whether you should do a treewide format-everything commit or this kind of slow burn is a matter of preference. In nixpkgs, people are already reformatting things they touch to nixfmt-rfc-style....
I had a quick look and it looks quite easy to add. I'm not using it myself so will wait until somebody else add it.
Try setting it on `programs.shfmt.indent_size` instead of `formatter.shfmt.indent_size`. Programs is the higher-level abstraction.
This could be solved by having treefmt-nix add the check to the wrapper's meta.tests. Then blueprint will pick it up like any other package's meta.tests.
@dyfrgi if you open a new fixed PR without the .md, I will try to get in contact with Guillaume to get this merged.
Thanks. Based on the previous conversation, I think we can assume that Guillaume is fine releasing his work under the MIT. The concern was more about how to go about...
A good way to test this would be if we have two sample: one formatted, and one unformatted. That should be enough to test most of the spec's feature in...