Jonas Chevalier

Results 1017 comments of Jonas Chevalier

## `nixpkgs-review` result Generated using [`nixpkgs-review`](https://github.com/Mic92/nixpkgs-review). Command: `nixpkgs-review pr 417102` Commit: `e64f6b49ffa3d1df3ffbb1123b7109bbf1a3b147` --- ### `x86_64-linux` :fast_forward: 2 packages blacklisted: nixos-install-tools tests.nixos-functions.nixos-test :white_check_mark: 1 package built: zerotier-systemd-manager

This requires changing the logic so that formatters are getting loaded lazily. Right now, all the formatters are getting loaded regardless of the passed list, and generate the error at...

As a Nix user, I expect to be able to pin the versions of my software, and that treefmt would use those same versions. I don't really see how this...

I haven't touched this yet. I was going to look at https://github.com/goreleaser/goreleaser-action for inspiration, but this one is probably much simpler. The user is responsible for the dependencies. They might...

@isbecker nice! Thanks for working on this. The lack of Windows releases is an oversight. Windows support has yet to be thoroughly tested and might have some issues.

On the plus side, it would ensure that treefmt-action is exercised. On the negative side, it will probably complicate maintenance by creating a circular dependency.

Next step is to make it more visible. 1. Add it to our docs. 2. If you want, move it next to the main repo? 3. Publish to GitHub Marketplace.

It's possible to reduce memory consumption a lot by only including the modules that you use in the `baseModules`: https://github.com/nixos/nixpkgs/blob/a3f0ef0a1fe3bc4a0d9eb176fcac246634d413c2/nixos/lib/eval-config.nix#L16-L17 Unfortunately `nixos-rebuild` doesn't support passing that parameter during evaluation. What's...

You got it. It will be quite painful to build the full list as module inter-dependencies are not being tracked, but that's the best (only?) way to reduce memory usage....

What's good about the activation script is that it displays errors directly to the user switching the system. I can see how this is useful for critical components, or to...