Fabian Zickgraf

Results 28 comments of Fabian Zickgraf

I have solved this problem in our CI by calling `LoadPackage` in a testfile, see e.g. https://github.com/homalg-project/FinSetsForCAP/blob/b5772d3fbc182b783a784ac1ebcb71b568d6baa2/tst/100_LoadPackage.tst#L8 Any syntax error triggered in line 8 fails the test.

> Let's see what other people have to say before you make further changes Yes, that's why I didn't invest time into adding documentation and tests yet :D > but...

@fingolfin I see. I am carrying around some downstream patches anyway, so I am happy with simply keeping this patch for my local build for now, hoping for a official...

Sounds good, I would only propose one change regarding point 4.: I think it would be nicer if `PrintFormattingStatus` would always return a record. Code which expects a boolean would...

Mhh, I see. I cannot think of a situation where I not would want indentation, so "always indenting functions regardless of formatting status" sounds sensible to me. (At least, removing...

From reading your code section I assume that you have tried this in a REPL? My issue only occurs if the code is in a file. But your test is...

> Just for confirmation, I assume you downloaded the tarball from [www.gap-system.org](http://www.gap-system.org)? Yes, and this gave me https://github.com/gap-system/gap/releases/download/v4.12.0/gap-4.12.0.tar.gz

Aaaah, the way I am calling GAP in a script seems to disable readline: ``` #!/bin/sh # Frank L�beck # # Use this script inside the $GAPROOT directory (the top...

> This is an unfortunate side effect of the workaround for #5011 . Now that the .exe was built we could just restore the correct .tar.gz. Ah, I see. From...

Thanks for the fast investigation! From an outside point of view (i.e. without knowing about all the internal quirks involved :D ), your proposed solution sounds very reasonable. At least...