Hongze Zhang

Results 100 comments of Hongze Zhang

Committed Velox change in https://github.com/oap-project/velox/tree/2024_04_09

cc @liujiayi771 @ulysses-you I took the function in https://github.com/apache/incubator-gluten/issues/4039 but may delay the implementation. I see you have been actively working on aggregation functions in past a few of days...

> > Thank you @zhztheplayer for driving this, I think @liujiayi771 is the better one to take it :) > > @zhztheplayer I can come to add these aggregate functions,...

> - [ ] percentile_approx > - [ ] approx_percentile: "Third argument accuracy is different with velox, velox is double but spark is long" The two stand for the same...

> - [x] collect_list (velox supported, needs Gluten to enable array for project plan node) > - [x] collect_set @PHILO-HE Should we uncheck these two? I ran a test and...

> Integration test with uniffle manually `gluten-celeborn` has a GHA action job [here](https://github.com/oap-project/gluten/blob/69838984034b0fae4eb0bd9adaf581ee66c83ba8/.github/workflows/velox_be.yml#L296). Is it possible for `gluten-uniffle` to add a similar one? Another option is to add some UTs,...

> UniffleColumnarBatchSerializer Is it possible to reuse `ColumnarBatchSerializer` somehow ?

Both this image and the one from [another repo](https://github.com/danielguerra69/ubuntu-xrdp-docker) have this problem.

Tried with the fix and it worked perfectly so far. Thanks for sharing @harcokuppens !