Hongze Zhang

Results 100 comments of Hongze Zhang

> do conversion work in native side, maintain a function name maps which map function name to target Any reason to maintain another mapping? We already have one mapping file...

Log with https://github.com/facebookincubator/velox/pull/9333 https://gist.github.com/zhztheplayer/580190d9078e895676b4c8454b7eadf5

Will be fixed by https://github.com/facebookincubator/velox/pull/9334

@sagarlakshmipathy @rhh777 @loukey-lj For compression type 2, It might because of lack of compression type LZ4 (not 100% sure about it, the message "Compression type 2" is blur) https://github.com/facebook/folly/blob/main/folly/compression/Compression.h Would...

@rhh777 @loukey-lj @sagarlakshmipathy If your issue was found with Gluten's static build, it should be fixed by https://github.com/apache/incubator-gluten/pull/5121.

I can think of a problem that when we update the Velox branch for some reason without changing Gluten's code, the cache should be manually invalidated otherwise will still be...

@zhouyuan A way to trigger rebuilding is needed anyway. I will raise a new PR for that. Thanks for the suggestion.

Update: This cache doesn't seem to be able to share among PRs. https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#restrictions-for-accessing-a-cache. It's OK for now and may need further improvements though.