Zhijun Liao comments

Results 14 comments of


                                            Zhijun Liao

containerd crashing with - panic: freepages: failed to get all reachable pages

Hi vikumar could you provide detailed steps to reproduce the issue?

Cluster: Assign default human-readable node name when starting server

@hpatro Thanks for reviewing! > I generally use the first/last few characters of node-id while searching and I've never seen it conflicting with other node's id. Yeah the first/last few...

Cluster: Assign default human-readable node name when starting server

> Fair. However, I don't see a mechanism for a user to disable printing the human nodename i.e. one can't set to empty. Rather setting it to empty would lead...

Cluster: Assign default human-readable node name when starting server

@zuiderkwast > it also affects the output of commands like CLUSTER SHARDS and CLUSTER NODES Actually it won't. `CLUSTER SHARDS` shows the node's hostname but not the human nodename. `CLUSTER...

Cluster: Assign default human-readable node name when starting server

@zuiderkwast Sounds good! I just added the helper function `humanNodename` and removed all changes previously used for feature "Users reset human nodename to empty".

Cluster: Assign default human-readable node name when starting server

@zuiderkwast Friendly ping ☺️

Cluster: Assign default human-readable node name when starting server

@enjoy-binbin > ip:port could be the nodename, but they are not the same thing My intent is not to say “ip:port is the same as nodename”, but: “if the user...

Cluster: Assign default human-readable node name when starting server

@zuiderkwast Thanks for the reminder! The outdated content did cause much confusion. Updated the title and description accordingly.

Cluster: Assign default human-readable node name when starting server

@zuiderkwast Should we merge this now that it's approved?

Refactor TCL reference to support running tests with CMake

> I think this will probably solve the problem but I have some drawbacks: > > 1. I don't much like the use of symlinks if it can be avoided....