Tan Zheng Wei

Results 12 comments of Tan Zheng Wei

I'm more inclined to agree with Tom. The current implementation takes this decision out of the hands of the user, and if this were really necessary, should be a separate...

Seems like you just need to set `mainRepositoryMapping = event.getMainRepositoryMapping();` in the [SkymeldUiStateTracker#loadingComplete](https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/runtime/SkymeldUiStateTracker.java#L166) method. `SkymeldUiStateTracker` overrides that method - so the repository mapping wasn't set for the Skymeld case and...

@coeuvre Might this be a possible application of Loom?

Overall I do like many aspects in the structuring of this code w.r.t cgroups, but I would like this to eventually be upstreamed into `CgroupsInfo` and `CgroupsInfo{V1,V2}`. That'll involve some...

> Yes, this is opaque to all the users of `VirtualCgroup`, which see all the controller as if they come from the same (virtual) cgroup :) That's what I love...

Will review this next week - have more pressing work upgrading Bazel's Java language level to 21 (which will be very soon!). Will also need to get this tested internally...

(I'm working on cleaning this up internally now).