Zhengfei He
Zhengfei He
`is_reading` has already been implemented in this pr: #17425. We can close this issue
Hi I'd like to work on this issue. Can you re reassign this issue to me @tigercosmos ?
> @zhengfeihe next time don't resolve the issue yourself, so other people can easily track the issues. Also, could you let the tests pass? Thanks for the reminder. I will...
> @zhengfeihe As we previously discussed, it appears that FreeBSD cannot easily share its implementation with macOS. Therefore, let's separate the FreeBSD implementation from macOS, allowing the macOS implementation to...
> @zhengfeihe could you check if the current test already covers your change? if not please add the corresponding tests. Also, please modify the description of the PR to explain...
> This PR is quite complex, I need to go over it carefully... @zhengfeihe can you share a link to the source code of `route` and some references on how...
@seladb Can you take a final look at this, and if there are no further comments, we can merge it?
> Thank you so much @zhengfeihe for working on this, very much appreciated! 🙏 ❤️ Glad finally get merged! Thanks for all your kind help and review on my first...
I'd like to work on this after I finish my current pr.
> @zhengfeihe are you still planning to work on this? Yes.. Just got delayed onmy current pr. I will start working on this soon.