Results 61 comments of zhao, zhenhui

> > Linux-adapters will run Substrait tests. > > Awesome. Please, update PR description to clarify. > > `Add Substrait tests CircleCI job linux-adapters.` Ok, thank you.

Hi, @majetideepak I fix all comments, would you please review again? Thank you.

> @zhejiangxiaomai I ran substrait-validator from https://github.com/substrait-io/substrait-validator on q6_first_stage.json file present in latest main and it shows a lot of errors. I wonder if some of the errors are being...

Hi, @mbasmanova I reproduced the problem about "extension_uri_reference" by using substrait-validator. In fact, we do not use this field now, and I think this PR's aim is update protobuf and...

> @ChengjieLi28 I ran into the same problem and made a similar fix, but substrait tests started failing because checked in .json files need updating. > > I'm surprised that...

> This PR is a draft now and @zhejiangxiaomai will help improve this PR. Yes, will do it this week.

Hi, @mbasmanova Could you please take a look at this PR? I rebase it just now. Thanks.

Hi, @mbasmanova I fix all comments now, could you please review again?

Hi, @mbasmanova would you please review this PR again? The major change is add "null value in array" case in arrayLiteral.

Hi, @mbasmanova sorry for the late reply. I iterate this PR. There are several major updates: 1. use template function toSubstraitNotNullLiteral to avoid twice type cast problem you mentioned before....