Fix velox with substrait build

[ChengjieLi28]

When I execute the command CPU_TARGET="arm64" make debug EXTRA_CMAKE_FLAGS="-DVELOX_BUILD_TESTING=OFF -DVELOX_ENABLE_SUBSTRAIT=ON" NUM_THREADS=16 MAX_HIGH_MEM_JOBS=8 MAX_LINK_JOBS=16 on my M1 MacBook Pro, I got the following errors: logs.txt

And I try to use Intel CPU device to build velox with substrait, using the following Dockerfile to build velox with substrait in a ubuntu 22.04 environment. Dockerfile.txt I still got the same error.

See also in #2332 .

Therefore, I propose this PR to fix this issue. With this change, I can build velox with substrait successfully.

[facebook-github-bot]

Hi @ChengjieLi28!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[netlify[bot]]

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	d8f4682d66ad551ff8cd2c5d041f847d56f7771a
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/62ff42a36dc14300086dd881

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[mbasmanova]

@ChengjieLi28 I ran into the same problem and made a similar fix, but substrait tests started failing because checked in .json files need updating.

I'm surprised that CircleCI jobs are not failing. Looks like Substrait tests are not running. Let's modify the configs to make sure Substrait tests do run on each PR.

CC: @kgpai @zhejiangxiaomai @rui-mo

[rui-mo]

@ChengjieLi28 I ran into the same problem and made a similar fix, but substrait tests started failing because checked in .json files need updating.

I'm surprised that CircleCI jobs are not failing. Looks like Substrait tests are not running. Let's modify the configs to make sure Substrait tests do run on each PR.

Hi, we found the previous arg was deprecated in Substrait 0.7.0 version, and could not compile on protobuf 3.13 or higher version. @zhejiangxiaomai can help to update the json file and enable the Substrait tests.

[zhejiangxiaomai]

@ChengjieLi28 I ran into the same problem and made a similar fix, but substrait tests started failing because checked in .json files need updating.

I'm surprised that CircleCI jobs are not failing. Looks like Substrait tests are not running. Let's modify the configs to make sure Substrait tests do run on each PR.

CC: @kgpai @zhejiangxiaomai @rui-mo

https://github.com/facebookincubator/velox/pull/2383 Hi, @mbasmanova @ChengjieLi28 I make a PR for this problem. Can you review it.