zhaoyunxing

Results 20 comments of zhaoyunxing

This is the x-pack that didn't pass,you can see:https://github.com/zhaoyunxing92/elasticsearch-head

You can see:https://github.com/zhaoyunxing92/elasticsearch-head,I changed the code to fix the x-pack

设置`optional`是不是就可以了

其他获取key的方法是不是也有这样的问题呢

注册完成后添加几秒睡眠 ![image](https://user-images.githubusercontent.com/18088210/183320274-e169da99-90b5-45fb-b9c6-3e66d6d5b55c.png)

> > 注册完成后添加几秒睡眠 ![image](https://user-images.githubusercontent.com/18088210/183320274-e169da99-90b5-45fb-b9c6-3e66d6d5b55c.png) > > 是不是可以通过同步机制解决,而不是这种 sleep 的手段,就算是 sleep,sleep 多久算合适呢? 一般2秒就可以了

主要是`AbstractConfig#equals`方法没有看`parameters`的参数 https://github.com/apache/dubbo/blob/3.0/dubbo-common/src/main/java/org/apache/dubbo/config/context/AbstractConfigManager.java#L161-L167 ```java if (!(config instanceof ReferenceConfigBase || config instanceof ServiceConfigBase)) { for (AbstractConfig value : configsMap.values()) { if (value.equals(config)) { return (T) value; } } } ``` [AbstractConfig#equals](https://github.com/apache/dubbo/blob/3.0/dubbo-common/src/main/java/org/apache/dubbo/config/AbstractConfig.java#L959-L983) 方法列表没有`getParameters()`...

可以考虑下多环境切换问题