Gong Zhang
Gong Zhang
/test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-conformance-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-main /test pull-cluster-api-provider-vsphere-e2e-govmomi-upgrade-1-30-1-31-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-ci-latest-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-conformance-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-main /test pull-cluster-api-provider-vsphere-e2e-supervisor-upgrade-1-30-1-31-main
It's ready for a review. And I'll try to add some tests if possible to make codecov happy.
All comments addressed, it's ready for another review :-)
/test pull-cluster-api-provider-vsphere-test-main
> Once we have the manifests working. Let's please do one manual test with tilt/kind or something (with a real Kubernetes cluster not just unit tests) to verify the webhooks...
/test pull-cluster-api-provider-vsphere-test-integration-main
I'm testing locally with tilt for supervisor mode, but I think it's ready for an initial review while waiting for the test result.
Deployed a supervisor mode env with tilt and the webhook configs and manifests works fine. Please let me know if any others need to validate :-) 1. Checked webhook configs...
> We also need to change the path here: > > https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/5e47949a28d0da488b0c2ba37e8c0a175cc2ceb6/internal/test/helpers/webhook.go#L86 > > We may also need the similar thing for the supervisor then?! Perhaps we need to add...
Checked the test artifacts, the failed cluster is `quick-start-3x2kmb` and it's blocked at `WaitForOneKubeadmControlPlaneMachineToExist`, which seems blocked due to no ready node. From the kubelet.log, the latest error is CNI...