Feng Zhang
Feng Zhang
> @zhangfengcdt PR definitely isn't fully ready yet, but I want to hear your thoughts. What types of common tests should we include for each function? Originally, I was thinking...
> I moved old test code to `test_match_geopandas_series.py` and created a new `test_geoseries.py` for micmic the scala tests you mentioned. I guess for these ST_AREA and ST_BUFFER, [functionTestScala.scala](https://github.com/apache/sedona/blob/master/spark/common/src/test/scala/org/apache/sedona/sql/functionTestScala.scala) doesn't test...
> > Looks great! I think for the first step, we could target covering whatever these scala tests cover in exact results. > > That made perfect sense originally, but...
> Yes that makes sense, but the hard-coded outputs from the original scala tests would clutter up the codebase too much due to their sheer size (possibly like 1000+ lines...
@freamdx The issue is currently being worked on. Before the fix, I think you can use the following workaround to create the Hive table. ``` CREATE OR REPLACE TEMP VIEW...
CC: @jiayuasu @Kontinuation @wgtmac
> @mkaravel Thanks for the great comments. > > The scope of this PR is to > > 1. Add basic type read / write of Geometry and Geography type....
@wgtmac @jiayuasu I have made some clean ups of this PR and added some additional tests to cover the edge cases particularly for the invalid bbox scenarios. I added a...
> PR of adding logical types has been merged. Please rebase this on top of the latest commit, thanks! Thanks @wgtmac ! I have rebased and updated this PR. It...
@wgtmac Thank you for the very helpful review comments! I believe I’ve addressed them all and have also added and updated some tests. Could you please take another look and...