Zachary J. Fields
Zachary J. Fields
I added `-Wpedantic` to the `platform.txt` file, and there are too many warnings to paste in this issue. These should be addressed to ensure the stability of the platform. ```...
``` FQBN: arduino:renesas_portenta:portenta_c33 Using board 'portenta_c33' from platform in folder: /home/zak/.arduino15/packages/arduino/hardware/renesas_portenta/1.0.5 Using core 'arduino' from platform in folder: /home/zak/.arduino15/packages/arduino/hardware/renesas_portenta/1.0.5 Detecting libraries used... /home/zak/.arduino15/packages/arduino/tools/arm-none-eabi-gcc/7-2017q4/bin/arm-none-eabi-g++ -c -w -Og -g3 -fno-use-cxa-atexit -fno-rtti -fno-exceptions...
When a disconnect occurs, a reset message is provided to both the `_thing` and `_device` containers, but there is no subsequent call to `_thing.update()` or `_device.update()` to process the message...
This modifies the implementation to be compatible with `avr-gcc`, which can then be supported by the Notecard. The core change is to templatize the implementation on `CloudInt`. This allows the...
``` ~/Development/Arduino/libraries/ArduinoECCX08/src/utility/ECCX08JWS.cpp: In member function 'arduino::String ECCX08JWSClass::publicKey(int, bool)': ~/Development/Arduino/libraries/ArduinoECCX08/src/utility/ECCX08JWS.cpp:94:18: warning: variable length array 'out' is used [-Wvla] byte out[length]; ^ At global scope: cc1plus: warning: unrecognized command line option '-Wno-deprecated-copy'...
``` ~/Development/Arduino/libraries/ArduinoMqttClient/src/MqttClient.cpp: In member function 'int MqttClient::subscribe(const char*, uint8_t)': ~/Development/Arduino/libraries/ArduinoMqttClient/src/MqttClient.cpp:333:43: warning: variable length array 'packetBuffer' is used [-Wvla] uint8_t packetBuffer[5 + remainingLength]; ^ ~/Development/Arduino/libraries/ArduinoMqttClient/src/MqttClient.cpp: In member function 'int MqttClient::unsubscribe(const char*)':...
`SERIAL_RX_BUFFER_SIZE` is a define from the legacy Arduino Cores. - https://github.com/arduino/ArduinoCore-avr/blob/321fca0bac806bdd36af8afbc13587f4b67eb5f1/cores/arduino/HardwareSerial.h#L49 - https://github.com/arduino/ArduinoCore-megaavr/blob/5e639ee40afa693354d3d056ba7fb795a8948c11/cores/arduino/UART.h#L50 We use it to optimize large serial transfers, and it would be nice to see it specified...
``` ~/.arduino15/packages/arduino/hardware/mbed_opta/4.1.5/libraries/SocketWrapper/src/MbedUdp.cpp: In member function 'virtual int arduino::MbedUDP::endPacket()': ~/.arduino15/packages/arduino/hardware/mbed_opta/4.1.5/libraries/SocketWrapper/src/MbedUdp.cpp:76:22: warning: variable length array 'buffer' is used [-Wvla] uint8_t buffer[size]; ^ ```
``` ~/.arduino15/packages/arduino/hardware/mbed_opta/4.1.5/libraries/STM32H747_System/src/STM32H747_System.cpp: In member function 'uint8_t STM32H747::readReg(uint8_t)': ~/.arduino15/packages/arduino/hardware/mbed_opta/4.1.5/libraries/STM32H747_System/src/STM32H747_System.cpp:9:8: warning: unused variable 'response' [-Wunused-variable] char response = 0xFF; ^~~~~~~~ In file included from ~/.arduino15/packages/arduino/hardware/mbed_opta/4.1.5/cores/arduino/mbed/targets/TARGET_STM/TARGET_STM32H7/STM32Cube_FW/STM32H7xx_HAL_Driver/stm32h7xx_hal_rcc.h:29:0, from ~/.arduino15/packages/arduino/hardware/mbed_opta/4.1.5/cores/arduino/mbed/targets/TARGET_STM/TARGET_STM32H7/STM32Cube_FW/stm32h7xx_hal_conf.h:398, from ~/.arduino15/packages/arduino/hardware/mbed_opta/4.1.5/cores/arduino/mbed/targets/TARGET_STM/TARGET_STM32H7/STM32Cube_FW/STM32H7xx_HAL_Driver/stm32h7xx_hal.h:30, from ~/.arduino15/packages/arduino/hardware/mbed_opta/4.1.5/cores/arduino/mbed/targets/TARGET_STM/TARGET_STM32H7/STM32Cube_FW/CMSIS/stm32h7xx.h:223, from...