Zachary J. Fields
Zachary J. Fields
It is difficult, if not impossible, to pick up the version number coming across the wire.
Here is the motivation behind the pull-request, as fleshed out below... - Originally, the parser was built into FirmataClass which serves the host/server. - There was no notion of a...
Previously, we discussed that `FirmataMarshaller` and `FirmataParser` should only contain the core functionality and nothing more. Then in the future (think configurable Firmata) we would use the marshaller and parser...
`FirmataParser::detach` only checks for `START_SYSEX`, but `FirmataParser::attach` will accept any variable as `command` argument. To be consistent, it feels like `FirmataParser::attach` should require `START_SYSEX` or do nothing.
I will pick on `byte`, because it's the biggest offender. `byte` is nothing more than a `typedef` of `uint8_t`, but `byte` is not portable and `uint8_t` is. This is an...
`void FirmataClass::sendSysex(byte command, byte bytec, byte *bytev)` `typedef void (*sysexCallbackFunction)(uint8_t command, uint8_t argc, uint8_t *argv);` in `FirmataParser` Since parameter `bytec` is used for counting the number of bytes, it would...
It looks to me as if extended analog only covers analog write (PWM). How do you query or `REPORT_ANALOG` on pins greater than 15? Also, the `PIN_TO_ANALOG(p)` macro is architecture...
This is different from the rest of your calls, because it puts the same key that was used to invoke it back on the wire. Same goes for protocol versioning....
https://github.com/firmata/protocol/blob/master/i2c.md#i2c-config
``` 0 START_SYSEX (0xF0) 1 pin state response (0x6E) 2 pin (0-127) 3 pin mode (the currently configured mode) ? pin resolution (the resolution to support the mode)