Arseny Kapoulkine
Arseny Kapoulkine
I think we're all set with this; I've tested this on gcc/Linux, clang/Linux, clang/macOS and msvc/Windows and everything seems to function as expected, as long as the C++ standard is...
The only addendum is that the change ended up being more straightforward (in the sense that the only issues I've discovered in testing were of the "I'd think it would...
I've gone ahead and merged a change that enables string_view by default whenever C++17 is detected, as this, on further reflection, is probably as safe as opt-in. The only actually...
Filed earlier today as https://github.com/zed-industries/zed/issues/31759
`gcinfo` returned an integer number in 5.1: https://github.com/lua/lua/blob/98194db4295726069137d13b8d24fca8cbf892b6/lbaselib.c#L187-L216
You are testing `collectgarbage("count")`, not `gcinfo`.
Note, I'm not necessarily saying changing `gcinfo` to return fractional kilobytes is wrong; I doubt it will break any users. Just saying `gcinfo` always was like this. I'll also note...
Just a note, and I'm *not* suggesting a change here :) but if you ever hit the perspective distortion issues and want a quick fix, this switches from radial distance...
I can replace the second (or both?) with something weaker like should, I mostly want to make sure the incompatibility with skinning is explicitly called out.
I updated the skinning clause for now to say "should not". While I think there's no consistent implementation possible, I don't need this to be enforced strictly. But regardless of...