Arseny Kapoulkine
Arseny Kapoulkine
Out of curiosity, what is the motivation for including both WebP and AVIF as glTF extensions? Is there specific guidance on when an application should use WebP vs AVIF, and...
> It isn't quite cut-and-dried: there are certainly cases where WebP outperforms AVIF. But I think that is the general shape of things. It feels a little odd to have...
This is a good isolated starting point (modulo tests and adding the define to GitHub Actions / AppVeyor config). I think it's fine to delegate to existing overloads when they...
> For gcc/clang my approach seems to work, for Windows I'm not so sure: (and I can't test locally) For all of them, this should be an expansion of the...
If you want that combination I think it can be added by adding `"PUGIXML_WCHAR_MODE,PUGIXML_STRING_VIEW"`. In general pugixml doesn't test all permutations on GHA as there are too many; I could...
Merged as #633, thanks!
I think the implementation should be in the `.cpp`. This is not different from other defines like PUGIXML_NO_STL et al that should be consistent between compilation and uses. In the...
Existing setters with size store the full span but since the length isn’t stored, the user visible behavior is the same (modulo a slightly higher memory consumption). Note that XML...
This is now implemented on master (thanks @brandl-muc and @dantargz!); the following code compiles and works when `PUGIXML_STRING_VIEW` define is set and latest clang/gcc are used (also demonstrating transparent support...
Ah, fun. It's fine to combine them in one PR if that's easier but either way works.