Jesse Haka

Results 165 comments of Jesse Haka
trafficstars

ping @sam-burrell could you check the review comments

I would not accept this solution because using PATCH http method this can be solved correctly. Now there is possibility that someone else will update configuration between these two requests...

That is true. However now there was different syntax before 1.0. For newbies its difficult to understand which one they should use because you cannot say that easily if you...

Well then its enough :) So if there is breaking changes after 1.0 I hope that version is added to schema

ping @knqyf263 any change to get reviews for this?

I can confirm this, xml is not valid. Do we really need this `` element?

@vikaschoudhary16 when you start implementing this, my use case is that I would like to use JWT claim like "email": "[email protected]" for RBAC. Also I would like to use JWT...

yeah actually @dulek had quite good point. /approve cancel

@nicolaslacroux for me the spec seems valid. Another option could be add `loadbalancer.openstack.org/proxy-protocol-version` annotation to specify the version. However, as I see it we could do it in one annotation...