Jesse Haka

Results 220 comments of Jesse Haka

@arkodg I did some tests with the api spec. The authorization commit can be seen in https://github.com/zetaab/gateway/commit/65885b551ef53ab1ff5cd24f032bdd9ecab4d762 1) other rbac stuff (like jwt authorization) can be implemented under clientselectors and...

case 5 ``` authorization: rules: - clientSelector: - clientCIDR: - 44.94.107.109/32 action: Deny ``` result: single ip address is denied case 6: ``` authorization: rules: - clientSelector: - clientCIDR: -...

@arkodg I would like to move to coding phase in case of this API. This PR now contains more than 40 reviews, kind of saying: how much more is still...

@arkodg modified the field now, as 1.0.0 is released I could continue working on this?

@arkodg well not really, I have tried to get it done but always something is missing. So I have kind of lost energy to do anything. If someone want to...

IPs could be useful together with jwts. For instance, if I have /admin path. I want allow it only for admins which are coming from cidr x

@arkodg @zhaohuabing is there something that we could now do to get progress to this issue? I would really like to see this authorization feature. IMO it should be started...

@arkodg @zhaohuabing please review. I have updated the PR according the spec Examples allow all subjects to GET method ``` rules: - permissions: [GET] action: "Allow" ``` allow 1.0.0.0/8 and...

@arkodg your comments are not down the line what was talked earlier in comments. So I do not know what to do here. If I do changes that you asked,...

that will look like ``` authorization: rules: - action: Allow policies: - subjects: - clientCIDR: 1.1.1.1 permissions: ["GET"] ``` I am fine with that. At least it should support many...