Steven Spriggs
Steven Spriggs
> is there any way to avoid making `aria-describedby` a required public attr? I'm don't know of or I am not seeing a way that isn't going to be bound...
@coreyvickery I can pick this up if necessary
Note to self: check docs PR to see if this was fixed. https://github.com/RedHat-UX/red-hat-design-system/pull/1465
Given several changes around demos and `ux.` refactor this does not appear to be an issue anymore.
Looks like there is a `rh-context-provider` in that panel that was missed during the `rh-context-provider` -> `rh-surface` transition. I can remove it. I don't think we would want someone combining...
> @zeroedin looks like some unrelated changes got committed? Oops sorry will get that fixed up.
> LGTM > > small-but-possibly-important note: if this only does youtube, maybe we should call it `` or ``? My vote would be `rh-video-embed` as it leaves it open for...
> In dark color contexts, the play button could indeed have more contrast. Ok will move to an issue. > Is this ready to merge? 🚀
Issue created: https://github.com/RedHat-UX/red-hat-design-system/issues/1758
@coreyvickery Just FYI had a short conversation with @eyevana about `compact` on `rh-tag` today, maybe get her use case for that as well?