Mustafa Zengin

Results 19 comments of Mustafa Zengin

Related internal work item: https://microsoftgraph.visualstudio.com/Graph%20Developer%20Experiences/_workitems/edit/13822/

Should this be called "CredScan as a PR gate" instead? As far as I understand, pre-commit hook is a dev setup thing. Unless this issue refers to something else that...

@MIchaelMainer we are adding it as a gate too in Raptor in case the secrets slip through from the dev setup: https://github.com/microsoftgraph/msgraph-sdk-raptor/pull/955.

I'd say yes. One is to prevent it from happening, the other is to catch if it happens. I think we have a way to catch it after the check-in...

That said, as @MIchaelMainer said, "pre-commit hook" is not really a work item specific to the repo.

cc: @nikithauc @sebastienlevert @ddyett as I hear similar thoughts floating around regarding TS/JS SDKs.

@baywet, this is a new one for the kiota checklist. Is this resolved by kiota?

Based on the following comment, it looks like we need an additional signal from the metadata. https://github.com/microsoftgraph/microsoft-graph-docs-contrib/issues/2833 @darrelmiller: > This isn't a doc issue. This is an SDK issue. In...

I think there might be two separate issues here. I agree that there is a discrepancy between metadata and the ref request in the docs. I will follow up on...

structural property problem is actually one level up: ```xml ``` https://docs.microsoft.com/en-us/graph/api/b2xidentityuserflow-put-apiconnectorconfiguration?view=graph-rest-1.0&tabs=http ``` PUT https://graph.microsoft.com/v1.0/identity/b2xUserFlows/B2X_1_testuserflow/apiConnectorConfiguration/postFederationSignup/$ref ``` `apiConnectorConfiguration` is what takes us to the complex type `userFlowApiConnectorConfiguration` in the metadata quoted above....