Nathan Zender

Results 20 comments of Nathan Zender

From what I can tell there are no limits to the length or if it is its much greater than what we will need. See test and output at this...

> Would enhancing/extending an example diagram, or introducing a new one which demonstrated this be warranted? Yah I'll look to add that.

> Would enhancing/extending an example diagram, or introducing a new one which demonstrated this be warranted? Done in 1cc6f6d Here is a screenshot of the example when running locally. ![screencapture-localhost-3000-docs-getting-started-examples-2020-10-03-21_17_21](https://user-images.githubusercontent.com/1099906/95004789-ec848e00-05bd-11eb-8519-6e1ec73bbe97.png)

> I think you made the same mistake here that I did with my Opnsense PR. I was steered to review https://github.com/mingrammer/diagrams/blob/master/CONTRIBUTING.md So what mistake are you referring to?? I...

> @zendern can this be merged? I'd love to use it! @AngelAlvarado I would like to think so, I do not have merge rights so I cannot just do so....

> LGTM. But you should resolve the conflicts. Thanks for the 👍 Conflicts are all cleaned up. This should be ready to go.

Started to look at this and quickly realized that this issue in the datadog-api-client-go needs to be completed first before this can be done. https://github.com/DataDog/datadog-api-client-go/issues/1308

That would be a cool addition. Should be easy enough to add I would think as an output format. Might be useful to use this library or maybe there is...

@deadlysyn welcome and im glad to hear you want to lend a hand. As for this yeah we already have compile/build as part of your docker container build but that...

@deadlysyn re: brew... thats neat i never realize brew was not just a macosx thing.