Zen

Results 29 comments of Zen

Hi @VegardIversen, it should definitely return a plot as you said, since the default is `show=True`. Here we call the pandas `plot()` function instead rather than matplotlib `plt.show()`. Can I...

Ah I think I misunderstood - I realize now that you're asking this more for conceptual understanding rather than asking for help to enable plotting! Yes you're right about `plt.show()`...

Hmm I didn't think it would be a problem since we have `return fig` which should act similar to `plt.show()` (as with most of neurokit's plotting functions). Thoughts? @DominiqueMakowski

> I'm not sure what's the standard way to achieve that. In any case, we should at least be consistent and adopt the same approach in all our plotting If...

Possible overlay of rsp and ecg signals, extracted from [here](https://www.researchgate.net/publication/333203340_Recent_development_of_respiratory_rate_measurement_technologies) ![image](https://user-images.githubusercontent.com/54053748/114506249-19e47f80-9c64-11eb-8fb3-cd282d081908.png)

Hi @CeliaBenquet Is your data.csv file the simulated signal? What was the method that you used with `ecg_quality`? I might be missing something here but using your instructions, I managed...

I see, thanks for clarifying! You're right in that the error is due to `ecg_findpeaks` rather than `ecg_quality` which requires the former to work in order to compute quality indices...

Tagging @anshu-97 and @claudia-liauw here 😄

Hi @CReizner thanks for catching this! Indeed you're right, it should be `rpeaks=rpeaks` rather than `rpeaks=None` in `ecg_process` to avoid peak computation again. Would you like to open a [pull...

This is probably due to the later step of sanitizing the columns in `epochs_create` (the int8 signal is detected as an object and then rendered as a string) https://github.com/neuropsychology/NeuroKit/blob/abfd08db61d9d9142d796fd2efac149e8f4636e7/neurokit2/epochs/epochs_create.py#L162-L176 Even...