Simon Pieters

Results 719 comments of Simon Pieters

I've updated the PR to incorporate @annevk's suggested changes.

> Shouldn't the test be using valid ARIA? Tests should exercise UA requirements and verify that the requirements are followed, irrespective from any author requirements. In https://w3c.github.io/accname/#computation-steps I see >...

I checked httparchive (only sample_data which is 10k pages) for resources with `.class = ...` to see if something looks like it could break if we add `class` to `Element`....

> Maybe use counters could be useful here? I filed https://issues.chromium.org/u/1/issues/367992694 . If that is implemented, then when it's in the Stable release the next httparchive run should have accurate...

@Psychpsyo nice! Yeah, this change has the potential to make some content do what the author intended, which would be nice indeed. However, the web is big, and there's still...

@123mansha great, thank you! 🎉 The test would be a testharness.js test, using the `test()` function, and doing the same thing as http://software.hixie.ch/utilities/js/live-dom-viewer/saved/3912 (but using `assert_equals()` instead of logging with...

@Hemali91 great, thank you! Did you look at the links in my previous comment?

The point of tests in web-platform-tests is to expose inconsistent behavior, so that browsers can fix the bugs that cause the inconsistency. As for guidelines, see [my comment above](https://github.com/web-platform-tests/wpt/issues/2611#issuecomment-723016574). Thanks!