Simon Pieters
Simon Pieters
That's a known bug of the diff preview.
Thank you for the review, @carmacleod! I've addressed your comments. I think you're right that the remediation use case example shouldn't add landmark regions.
I have addressed the comments. 2 examples are new. Please review. 🙂 @JAWS-test ARIA doesn't put any limit to `aria-level` currently. Is the limitation in JAWS only for `heading`? Should...
OK. I see that you have filed https://github.com/w3c/aria/issues/1050 already.
@carmacleod can you review this? Thanks!
The HTML diff service gave a 500 error when the PR preview ran. Now the service seems to be OK again, so I'll close and reopen to rerun PR preview.
@jongund you had some comments about the examples in https://github.com/w3c/aria-practices/pull/1109#issuecomment-550030262 . The examples have been changed since that telecon. Would you like to review? Thanks!
@jongund > I would recommend changing the class names in the following example: This is under "Remediation" - the assumption is that the original markup is bad, but can't be...
I have added a note about heading levels > 6. I have also tried to address @jongund's comments.
@jongund, @carmacleod, can you review the latest 2 commits?