Simon Pieters
Simon Pieters
I did not get to this today unfortunately. cc @richnoah
Thank you for the review @a11ydoer! I've addressed the comments and moved the text into `aria-practices.html`, and rebased on latest master. If this looks OK, I believe this is ready...
Thanks for the review! I've addressed comments, except I didn't add `focusable="false"` https://github.com/w3c/aria-practices/pull/1045#discussion_r322718328
Thanks @JAWS-test and @carmacleod. I think it is a reasonable balance to include and document simple workarounds for unmaintained and widely used implementations, while in general assume conforming implementations.
@a11ydoer or @carmacleod, can either of you review this? Thanks!
> Consider making section 9. Excluding subtrees from the accessibility tree and section 10. Intentionally Hiding Semantics with the presentation Role be subsections of section 8. Accessibility tree. Done.
> Consider adding something to the effect of "don't put aria-hidden on interactive content". to the warning box at the end of section 9. Excluding subtrees from the accessibility tree....
@carmacleod can you review the latest changes? Thanks!
I don't think this section needs to be blocked on https://github.com/w3c/aria/issues/915 - we can update APG if necessary when ARIA changes, and have an open issue for APG to track...
https://github.com/w3c/aria/issues/915 has been resolved, and I've now updated this PR.