Cindy Zhang
Cindy Zhang
> Made some minor nits and suggestions. Thanks @dmatrix, addressed!
> @zcin you have a merge conflict @edoakes Fixed!
@edoakes Tests are passing!
@anyscalesam I took a look at this and it seems to be failing for some obscure reason. Will take a bit more time to look into it, but may leave...
This has been removed from our release tests and replaced with `serve_autoscaling_load_test`
Windows tests unrelated.
@edoakes @sihanwang41 Addressed comments, PTAL!
> Looks good! Does the new test fail without the change from this PR? (If not, we should have a test like that) Yup, the new `test_stop_job_timeout` fails before this...
Please lmk if anyone thinks there are other unit tests that I should update!
@edoakes Have yet to add any new tests, but ready for first round of review!