zchn

Results 28 comments of zchn

Hi @TheAppleTucker , could you follow the guide here to submit smart contract addresses instead? https://github.com/ethereum-optimism/superchain-registry/blob/main/CONTRIBUTING.md#adding-a-frontier-chain

> Hey @zchn the mentioned required checks [codegen](https://github.com/ethereum-optimism/superchain-registry/pull/125#discussion_r1528661120): `ci/circleci: check-codegen` & [Security configs](https://github.com/ethereum-optimism/superchain-registry/pull/125#discussion_r1528658258) `ci/circleci: check-security-configs` are now successful. Thank you! The golang-test also needs to pass, there are 4 failures...

> @zchn We are in the process of redeploying the testnet. Keeping the Ecotone in mind do we need to use op-contracts 1.3.0, because I saw it contains new [preinstalls](https://docs.optimism.io/builders/chain-operators/features/preinstalls)...

> @zchn We are waiting for @sbvegan to come up with the solution, whenever he's available, so that we can pass all the checks in one shot without doing multiple...

Hi @nitantchhajed , Sorry for the delay in responses and thank you for your patience. All technical checks have now passed and this PR is ready to be merged in...

+1 for option 2: Use the incoming "shortname" variable

works for me. but only because I'm not the one adding any yamls :) probably we need to check with code owners of the yaml files and make sure it...

Hi @clabby , can you move this to the sep/ folder instead of a new sep-dev folder? after that, no review from security-reviewers are needed.

Merged https://github.com/ethereum-optimism/superchain-ops/pull/202 so this PR no longer needs review from @ethereum-optimism/security-reviewers

hii, no review from security-reviewers is needed for this one so I removed me and maurelian