zbarbuto

Results 42 comments of zbarbuto

Sadly doesn't seem to work with images - any advice on what I need to change to support this? Would applying the same wrapper in `_recursiveLexer` be the best place?

Sorry for the ping @erickok but do you have any feedback here and/or any advice for the best way I can make this work for inline images as well?

I managed to get it working for images as well with a few tweaks: ![image](https://user-images.githubusercontent.com/9100419/140671494-3e7cfa14-82ee-4a03-8b2e-fa29c1fdcccd.png) Turns out there was a bug in the image renderer which wasn't passing the correct...

Have rebased on latest master.

The Dart auto-formatter seems to have been a bit aggressive - is there a custom print-width I need to use or something to avoid the extra unnecessary diffs?

@tneotia No problems. Please leave this PR open for now and hopefully I'll have some time this week rebase on master without the auto-format changes rather than make a new...

@tneotia Ok I've cleaned the diffs and fixes a few issues that were inconsistent with normal HTML behaviour. The demo has been updated to show these edge-cases: ![image](https://user-images.githubusercontent.com/9100419/147164949-f360e517-71d5-4b5d-bab9-2dfe84a55418.png) I previously...

Whoops - typo in the fuschia example - fixed: ![image](https://user-images.githubusercontent.com/9100419/147165297-bed41441-4bed-45b7-a7d1-45a703877505.png)

I have rebased and applied my changes. There is an issue that has come up after rebase in that divs are not displaying as block-level correctly which breaks their alignment...

@tneotia sorry for the ping but anything further I need to do on this since it has been rebased? I can create a separate issue for the block display problem...