Ezekiel Warren

Results 78 comments of Ezekiel Warren

I meant to work on this a long time ago. I created a PR for it now https://github.com/doctest/doctest/pull/797 😅

understandable. I had gone off this trail to add official support a while ago. I might pick it up again with a more complete setup as you rightfully criticized. If...

The codecov report seems to be inaccurate. It's complaining about a file that I haven't touched 😅

That would be better than having no support. I would prefer direct execute for all platforms. I tend to work with Windows, Linux, and macOS and direct is more consistent...

@oknozor done! Let me know if you'd like any changes.

> Merging it when our design concerns are met might be an option. I like this option. Allow the community to develop this sooner than Google's timeline, but let us...

I'm a little confused by the CI error. Patch seemed to fail on some Windows CI (but not others) and then there's an error on some of the Debian CI...

the presubmit seems to read it for example here: https://buildkite.com/bazel/bcr-presubmit/builds/5043#018f2bef-01c2-40ac-a4c6-8c9ff1401613/128-136

> Looks like your .bazelrc file has CRLF line ending? Yeah it was a mistake. I've made a PR to clean that up. https://github.com/Neargye/magic_enum/pull/358 > Coverting to LF line ending...

I have some BUILD files here https://github.com/zaucy/imgui if someone wants to use it as reference. It only has the `dx9`, `dx10`, `dx11`, `dx12`, and `win32` backends though. It would be...