bazel-central-registry icon indicating copy to clipboard operation
bazel-central-registry copied to clipboard

add magic_enum

Open zaucy opened this issue 9 months ago • 3 comments

zaucy avatar Apr 29 '24 16:04 zaucy

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (magic_enum) have been updated in this PR. Please review the changes.

bazel-io avatar Apr 29 '24 16:04 bazel-io

I'm a little confused by the CI error. Patch seemed to fail on some Windows CI (but not others) and then there's an error on some of the Debian CI that doesn't give a lot of information

zaucy avatar Apr 29 '24 22:04 zaucy

bump on this :) No clue about the Windows error, but for the Linux one you could try to (temporarily) patch in a higher --experimental_ui_max_stdouterr_bytes in the .bazelrc?

stderr (/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/564d2f181201e0c9b383e74c8e273ef9/execroot/_main/bazel-out/_tmp/actions/stderr-10) 2099313 exceeds maximum size of --experimental_ui_max_stdouterr_bytes=1048576 bytes

lalten avatar May 10 '24 09:05 lalten

Why is patching the .bazelrc needed? I thought only the one in the project root would apply, and not the ones in modules you depend on

dieortin avatar May 31 '24 09:05 dieortin

the presubmit seems to read it for example here: https://buildkite.com/bazel/bcr-presubmit/builds/5043#018f2bef-01c2-40ac-a4c6-8c9ff1401613/128-136

zaucy avatar May 31 '24 19:05 zaucy

Looks like your .bazelrc file has CRLF line ending? Which doesn't match the patch file.

$ file .bazelrc
.bazelrc: ASCII text, with CRLF line terminators

Coverting to LF line ending could help with the windows failure.

meteorcloudy avatar Jun 03 '24 09:06 meteorcloudy

Looks like your .bazelrc file has CRLF line ending?

Yeah it was a mistake. I've made a PR to clean that up. https://github.com/Neargye/magic_enum/pull/358

Coverting to LF line ending could help with the windows failure.

For the patch file? In one of my previous commits in this PR I had the patch file using LF line endings and it failed https://buildkite.com/bazel/bcr-presubmit/builds/5038#018f2be4-1c33-4b6a-a0c9-3a29c6b62de1/147-180

I think what I'm going to do is just disable bazel 7.x so that patching the flag doesn't matter and then in the next magic_enum release 7.x can be added again.

zaucy avatar Jun 03 '24 15:06 zaucy

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (magic_enum) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 03 '24 15:06 bazel-io

Hello @mattyclarkson, modules you maintain (ape, rules_bzip2, rules_coreutils, rules_curl, rules_diff, rules_gzip, rules_squashfs, rules_zstd, toolchain_utils) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @alexeagle, modules you maintain (aspect_bazel_lib, aspect_rules_aws, aspect_rules_js, aspect_rules_lint, rules_buf, rules_oci, rules_proto, toolchains_protoc) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @kormide, modules you maintain (aspect_bazel_lib) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @CaerusKaru, modules you maintain (aspect_rules_aws) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @aspect-build, modules you maintain (aspect_rules_esbuild, aspect_rules_py, aspect_rules_rollup, aspect_rules_swc, aspect_rules_terser, rules_nodejs) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @gregmagolan, modules you maintain (aspect_rules_jasmine, aspect_rules_jest, aspect_rules_js, aspect_rules_ts, aspect_rules_webpack) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @jbedard, modules you maintain (aspect_rules_jasmine, aspect_rules_js, aspect_rules_ts) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @thesayyn, modules you maintain (aspect_rules_ts, rules_distroless, rules_oci, rules_proto) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @dzbarsky, modules you maintain (aws-in-a-box, libarchive, rules_itest) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @fmeum, modules you maintain (bazel_env.bzl, bazel_features, buildozer, gazelle, rules_fuzzing, rules_go, rules_jni) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @Wyverald, @meteorcloudy, modules you maintain (bazel_features) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @comius, modules you maintain (bazel_skylib, bazel_skylib_gazelle_plugin) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @zetten, @adincebic, modules you maintain (bazel_sonarqube) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @sergeykhliustin, modules you maintain (bazelpods) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @agl, @bob-beck, @davidben, modules you maintain (boringssl) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @curoky, modules you maintain (catch2) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @Vertexwahn, modules you maintain (catch2, cpuinfo, hypothesis, imath, libwebp, tinyformat) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @ewianda, @ColinHeathman, modules you maintain (com_github_benchsci_rules_nodejs_gazelle) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @illicitonion, modules you maintain (contrib_rules_jvm, rules_rust) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @gibfahn, @shs96c, modules you maintain (contrib_rules_jvm) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @martis42, modules you maintain (depend_on_what_you_use) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io

Hello @linzhp, modules you maintain (gazelle, hermetic_cc_toolchain, rules_go) have been updated in this PR. Please review the changes.

bazel-io avatar Jun 14 '24 20:06 bazel-io