zariiii9003
zariiii9003
Great example, thanks! Can `LongNamesConverter._database` and `LongNamesConverter._short_names` be removed entirely? I do not see any read access.
> I agree, they can be removed 👍 I assumed you'd remove them 😅
You could try setting the encoding `cantools.database.dump_file(db, dbc_filepath, encoding="utf-8")`
There is no need to perform range checks on decoding, if your bus description is correct and each node adheres to the rules as described by the dbc.
As one of the maintainers of python-can, i'd suggest to use the [`can.LogReader`](https://github.com/hardbyte/python-can/blob/bc3f95544e7a7dbec0da855a0873c6ea502147fc/can/io/player.py#L24) instead. It's a dependency of cantools anyway. Regarding the regex, i'll take a look at it later.
> I'm still not sure if its wise to support what appears to be a non-standard format produced by python-can (i.e. `(1594172461.968006) vcan0 1F0#0000000000001BC1 R` with that ` R` that...
The docstring of the `use_system_timestamp` parameter should warn, that this is incompatible with the IO-parts of python-can. The string splitting in ASCWriter is weird indeed, something like this should be...
> @zariiii9003 but you would keep the data type as int in milliseconds? Tbh, i don't know. Is the default `msg.timestamp` of a neovi bus not comparable to `time.time()`?? I...
I don't know tbh. But maybe [this](https://bitbucket.org/tobylorenz/vector_asc/src/c304a20a0cd49d15aeebafde777c5ca6d93a2fe6/src/Vector/ASC/CanCommon.cpp#lines-68) helps.