zarebski-m

Results 10 comments of zarebski-m

@alimate Hello, I have sadly missed your answer and the invitation; it has since expired. Could you re-send it to me?

@wimdeblauwe This looks really nice, I'd say that we can go this way. My only concern are changes to public API of `HandledException` which are exposed via library's extension point...

@wimdeblauwe It's better, but I'd like to mention that constructors are also part of public API. ;) It's especially important here because `WebErrorHandler` is effectively a `HandledException` provider which means...

@wimdeblauwe Thanks for your changes, I really like them. Regarding test cases: your changes definitely make sense to me and indeed are more readable. I'm not sure about rewriting all...

@wimdeblauwe It seems to me that this test case could indeed be wrong. There _should_ be two sets of arguments, one for each violated constraint.

@alimate Could you have a look at this PR?

For basic formatting yes, but I was thinking about full Java formatting rules: imports, javadocs, etc.

This has broader consequences: not only final fields are silently ignored, but also it requires all form params to be _actual fields_. I can imagine a scenario where form param...

@nakednamor Unfortunately, the project is effectively dead. I have no time to work on it, Ali also cannot contribute. If you need this library you can always fork it, I...

> Is your configuration using the keep_alive parameter ? His role is to regularly check the state of the switch is aligned with the thermostat. Hi, I know it's unrelated...