Vitaly

Results 213 comments of Vitaly

> Many of these checks are designed to prevent the bot from getting flagged/kicked by the server. Have you checked how this is handled my vanilla? Of course, it does...

@rom1504 Of course! It does work without any issues. The maximum length you can get is 45 characters on the line

GitHub Action says: ```js 1 failing 1) mineflayer_external 1.20.4v sign: Uncaught TypeError: Cannot read properties of undefined (reading 'trimEnd') at Timeout._onTimeout (test/externalTests/sign.js:23:42) at listOnTimeout (node:internal/timers:569:17) at process.processTimers (node:internal/timers:512:7) ``` The...

> If the max is 45 characters then why not adapt the check instead of removing it ? Okay, not a problem. --- As said in https://github.com/PrismarineJS/mineflayer/pull/3328#issuecomment-1996263771 In the original...

Is this good to go?

@extremeheat could you look into this as well? Don't see anything that blocks the pr

> entities are updated via rel_entity_move, which provides the positional data and not velocity And also stable api does not fire any event in this case so it's unclear how...

> exposed "entityMoved" that would allow you to calculate the velocity differential. However, I recall attempting to do what you are trying to do; this event fires every 100ms, meaning...

I forgot to say that I've successfully integrated your module but it allows you only to get the approximate velocity and still don't understand how to get the state of...

> why is it worth it to do such a breaking change for a minor renaming? where did you find the breaking change? the pr is here because of https://github.com/PrismarineJS/mineflayer/issues/3276#issuecomment-1881884816,...