mineflayer icon indicating copy to clipboard operation
mineflayer copied to clipboard

Published 20 hours ago • verified publisher icon PrismarineJS

Deprecate and rename `respawn` option to `autoRespawn`

Open zardoy opened this issue 1 year ago • 5 comments

fixes #3276

zardoy avatar Jan 08 '24 22:01 zardoy

why is it worth it to do such a breaking change for a minor renaming?

rom1504 avatar Jan 14 '24 15:01 rom1504

why is it worth it to do such a breaking change for a minor renaming?

where did you find the breaking change?

the pr is here because of https://github.com/PrismarineJS/mineflayer/issues/3276#issuecomment-1881884816, if for some reason you don't like it feel free to close it...

zardoy avatar Jan 14 '24 17:01 zardoy

Removing the option options.respawn is a breaking change

rom1504 avatar Jan 14 '24 17:01 rom1504

Removing the option options.respawn is a breaking change

But I didn't remove support for options.respawn, old option should still be supported. am I missing something?

zardoy avatar Jan 14 '24 18:01 zardoy

ah yeah I see, yeah then it's not breaking

not sure if it's really useful though, but maybe...

rom1504 avatar Jan 14 '24 18:01 rom1504