Błażej Szczygieł

Results 236 comments of Błażej Szczygieł

> Can i send it to you privately Yes, but I don't promise that fix will be easy/possible for now and I'll look at this later :)

I think I need to rewrite entire playlist code - it's just a mess now :smile:

Good idea, but dangerous (deletes files) - it must be disabled by default.

The (stupid) idea is that QMPlay2 doesn't know about YT, because it's an extension. But I'll check it soon!

> Indeed. Old habit ("compiler might be able to generate more efficient code"), plus I find it makes it easier to get reacquainted with the code flow if you haven't...

Or this: ```diff diff --git a/src/modules/Extensions/YouTube.cpp b/src/modules/Extensions/YouTube.cpp index d838ccb4..19e8dab4 100644 --- a/src/modules/Extensions/YouTube.cpp +++ b/src/modules/Extensions/YouTube.cpp @@ -436,7 +436,7 @@ bool YouTube::canConvertAddress() const QString YouTube::matchAddress(const QString &url) const { const QUrl qurl(url);...

Btw. where `youtube:` (without `//`) is needed? Without this `static QString fileArg(const QString &arg)` doesn't need to be modified, too :slightly_smiling_face:

> Btw. where `youtube:` (without `//`) is needed? > Well, yes, that was in fact my original intention (think of the mailto: protocol). IIRC I've had to support the slashes...

> Sorry, I wasn't clear: as per the issue title it was my intention to support the syntax _without_ slashes. You can argue that this is more appropriate too: "youtube"...

Could you send sample recorded file or URL?