Victor Zanivan
Victor Zanivan
Thanks for tackling this @Andarist! This was actually a workaround added in https://github.com/mui/material-ui/pull/42445/commits/dc92ade70e8d3f52a5dec2afb4a3a9bcd9892f89 to address the `test_types` check—that is currently failing :( It'd be good If you could fix the...
I’ll provide a bit more context—this shadow is based on the levels defined in Material UI's default theme. There are 25 shadow levels in total, starting from `0: "none"`. You...
> is the user required to configure all 25 levels? I understand they shouldn't configure more than 25 but is the system OK with less than 25? I think so—I...
> I think the proper fix here would be generating the 25 values for the templates theme, would that be possible @zanivan? That’s possible, but I don’t see why someone...
Since this isn't the right fix for the issue, I’ll close this PR for now.
Hey @prakhargupta1, I was talking to @joserodolfofreitas, and we agreed that we should take a few steps back before jumping into a PR for this. Since it’s a sensitive page,...
@DiegoAndai could you help me with failing tests? After fixing it, I believe this is ready for review :) `test_lint` seems to be failing on [this file](https://github.com/mui/material-ui/blob/f2a9520c0f47c1deb3c9cf76aece6f6c31f19efc/benchmark/server/scenarios/docs.js), but I don't...
@aarongarciah I forgot you were on PTO this week, so I'm merging this one to start working on unifying the themes and making it consistent. Feel free to add your...
@siriwatknp, these are the issues I found during my initial review. I won't dive too deep into visual tweaks for the templates, like the box-shadow on the marketing page appbar,...
> I thought the idea was to have duplicate theme files so each template would have all the code. This way users can clone one template without having to navigate...