material-ui icon indicating copy to clipboard operation
material-ui copied to clipboard

[draft][material-ui] Refine Blog template

Open zanivan opened this issue 1 year ago • 2 comments

Part of https://github.com/mui/material-ui/issues/37555

⚠️ Work in progress ⚠️
This is an initial draft and further improvements are expected.
Current Prototype
image image

Figma prototype

👉 https://deploy-preview-42825--material-ui.netlify.app/material-ui/getting-started/templates/blog/

zanivan avatar Jul 02 '24 17:07 zanivan

Netlify deploy preview

https://deploy-preview-42825--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad) No bundle size changes

Generated by :no_entry_sign: dangerJS against b856b5417211ce9b43ab85e566f81bdba1ef4172

mui-bot avatar Jul 10 '24 20:07 mui-bot

@DiegoAndai could you help me with failing tests? After fixing it, I believe this is ready for review :)

test_lint seems to be failing on this file, but I don't know exactly what it does.

zanivan avatar Jul 23 '24 20:07 zanivan

Hey @oliviertassinari! This template no longer uses markdown, so docs/data/material/getting-started/templates/blog/Markdown.tsx (and .js) were removed. We have a test that uses it here: https://github.com/mui/material-ui/blob/next/benchmark/server/scenarios/docs.js

Can we remove it from the benchmark test? Asking as you initially introduced the test (PR):

diff --git a/benchmark/server/scenarios/docs.js b/benchmark/server/scenarios/docs.js
index 25fa13feb8..a26b6d85cf 100644
--- a/benchmark/server/scenarios/docs.js
+++ b/benchmark/server/scenarios/docs.js
@@ -5,7 +5,6 @@ import Benchmark from 'benchmark';
 import * as React from 'react';
 import * as ReactDOMServer from 'react-dom/server';
 import { MarkdownElement } from '@mui/docs/MarkdownElement';
-import Markdown from 'docs/data/material/getting-started/templates/blog/Markdown';
 import { createStore } from 'redux';
 import { Provider } from 'react-redux';
 
@@ -28,9 +27,6 @@ const store = createStore((state) => state, {
 });
 
 suite
-  .add('Markdown', () => {
-    ReactDOMServer.renderToString(<Markdown>{markdown}</Markdown>);
-  })
   .add('MarkdownElement', () => {
     ReactDOMServer.renderToString(
       <Provider store={store}>

DiegoAndai avatar Jul 25 '24 20:07 DiegoAndai

@aarongarciah I forgot you were on PTO this week, so I'm merging this one to start working on unifying the themes and making it consistent. Feel free to add your feedback here or in an issue, and I'll address it in a future PR 👍

zanivan avatar Aug 02 '24 11:08 zanivan

Great work @zanivan. I didn't review the PR in depth, but a couple of details caught my eye:

  • It took me a while until I realized there was a theme switcher at the bottom.
  • The padding on the chips looks too tight.
  • The hover state on the chips maybe is a bit too subtle.
  • The hover state with the underline effect feels slow on the "Latest" articles. Maybe we could explore another effect e.g. underline all of the text rows in case of multiline title and use a fade-in effect instead of animating the underling. The underline taking the whole block widths feels a bit weird.
Screenshot 2024-08-05 at 14 43 46 Screenshot 2024-08-05 at 14 48 03

aarongarciah avatar Aug 05 '24 12:08 aarongarciah