Zanie Blue comments

Results 2920 comments of


                                            Zanie Blue

Add colored log levels

👍 I had some requested changes but they look addressed, will review again.

Agent: Add limit to control number of concurrent flow runs

@eudyptula thanks for the pull request! This looks reasonable to me. We may want to clarify that this is a limit on _running_ flows as we could also introduce a...

`Flow.serialize_parameters` can return invalid JSON representation

Can you share the full traceback please and the full suggested error message?

`Flow.serialize_parameters` can return invalid JSON representation

Hm, interesting. This should not be happening at all, actually. This error is happening when the `FlowRunCreate` object is being cast to JSON. This should be receiving parameters that are...

`Flow.serialize_parameters` can return invalid JSON representation

We have the option of using https://github.com/ijl/orjson#opt_non_str_keys but we'd only want to do so in some cases as there are other implications i.e. performance and key collisions. We also could...

`Flow.serialize_parameters` can return invalid JSON representation

I think the first step here is to solve our incompatibility between `orjson` and `json`. The dataframe here is just an example of how you can end up with non-string...

`Flow.serialize_parameters` can return invalid JSON representation

@ColeMurray can you please share the traceback?

`Flow.serialize_parameters` can return invalid JSON representation

Thanks! This should not be affected by results, it is definitely the serialization error for parameters this issue is about. You may be able to workaround this by using our...

`Flow.serialize_parameters` can return invalid JSON representation

We've assigned an engineer and a fix should be out in the next week — updates will be shared here as they come.

Error reading flow runs with async Orion python client

Thanks for the issue! Note we do not expect the client to be used in this way. Does this reproduce if you do ```python async def main(): async with get_client()...