Zachary Anderson

Results 331 comments of Zachary Anderson

An overall concern I have with this change is repeating the same mistake that we made with `tools/gn` in which every GN option is exposed to the user on the...

I think this is unrelated to the issue you're seeing, but RBE will not work if the version of Xcode you have installed locally is different from the version of...

> I can fix the bugs, or @jonahwilliams @zanderso is it time to turn off the Skia scenario tests? Or are those still valuable? Depending on how much trouble it...

There's no filtering in the tool AFAICT. (There's no `filter` argument passed to `batch` here: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/dart/pub.dart#L256).

From the logs linked above, `pub` is invoked as: ``` dart __deprecated_pub --verbose get --no-precompile ```

It looks like `dart __deprecated_pub` came from https://github.com/flutter/flutter/pull/89032.

FYI @jonahwilliams the text/font puzzle game demo lives here https://github.com/flutter/samples/tree/main/experimental/varfont_shader_puzzle.

Is this PR intended to fix the tree? It landed with the tree closed.

I see. For what you wanted, you should continue to use the `autosubmit` label. The tree being closed doesn't block submitting via the merge queue. Right now, it's just like...

> looks like that button served a different purpose, and the correct workflow will still be using autosubmit. should I revert this pr? That would be the safe thing to...