Zach Collier

Go also has an open issue for this: https://github.com/golang/go/issues/48298. dsnet wrote a great summary of the problem and I'd suggest a read. As far as implementation, this looks like it...

This is how I'm 1. building the Javascript file, 2. minifying using `esbuild` and 3. Adding UMD module support ([one liner](https://github.com/Cyphrme/qrgenjs/blob/d05054f5fd2842ccded90795724dd7a3b19ffbea/module_append.txt)): ``` tsc --strict --lib DOM,DOM.Iterable,ES6 --target ES6 1.8.0/ts/qrcodegen.ts --outFile...

What does properly disabling read only inputs look like? Especially for non-bootstrap components. For bootstrap, there's the static controls. https://v4-alpha.getbootstrap.com/components/forms/#static-controls

Yes! Absolutely! Other libraries do this. Here's one: https://github.com/nayuki/QR-Code-generator demo: https://www.nayuki.io/page/qr-code-generator-library code: https://www.nayuki.io/res/qr-code-generator-library/qrcodegen.js Here's another: https://github.com/kazuhikoarase/qrcode-generator demo:https://kazuhikoarase.github.io/qrcode-generator/js/demo/ code: https://github.com/kazuhikoarase/qrcode-generator/blob/master/js/qrcode.js

Alternatively to NPM, we've been using the JS files. We added the UMD module for supporting modules and not module importing: https://github.com/Cyphrme/qrgen See this line: https://github.com/Cyphrme/qrgen/blob/7776160432f435779c29a4c9cdd617cd52643cff/qrgen.js#L1084

Nayuki , thank you for your work! That's when I forked it and have not updated it since. I will update using the Typescript port, and include a Javascript minified...

Thanks Nayuki, ### TL;DR: May I suggest the following addition? ```sh tsc --strict --lib DOM,DOM.Iterable,ES6 --target ES6 *.ts esbuild qrcodegen.js --minify --outfile=qrcodegen.min.js && cat module_append.txt >> qrcodegen.min.js ``` ### Long:...

See Pull Request #269

I've looked at every other instance of "521" and everywhere else seems correct at a glance.

Ah! Yes you are totally right. If you don't mind, I renamed "expectedBitSize" to "expectedCurve" to avoid any future confusion.