Zak Henry

Results 78 comments of Zak Henry

This is by design, see https://github.com/dthree/vantage/blob/7e5a8019591f14bd0836875589c4795730c9e88c/lib/server.js#L195 - the callback is called on the socket connection event, not when the vantage server is initialised.

@srnagar I love this idea :) I actually have the same problem sometimes but haven't really thought much about it. I'll have a think and might take a crack at...

# Options for anchored embed Hi @srnagar thanks again for your feature request, I've put a bit more thought into it and realised there are few options/difficulties with the API...

Hi, I'm not familiar with asciidoctor, can you provide an example of how that might look with embedme?

Ahh right I getcha, is this essentally the same thing as https://github.com/zakhenry/embedme/issues/48 ?

So to clarify you're suggesting that an additional suffix be permitted that instead of defining which _lines numbers_ to embed, it defines which _lines matching an expression_ to embed? I...

Hmm yea I've been thinking about this a bunch and agree it would be an excellent addition, however I'm a little stumped on how to implement in in an ergonomic...

@Botosio nope not yet, I'm open to PRs though!

It's probably fastest to let the too many requests happen, then retry after the `retry-after` header says so: https://github.com/thepracticaldev/dev.to/blob/5b62811c9874fa2770fe3f720abac1f80fe6279f/spec/requests/api/v0/articles_spec.rb#L564

Here's a minimal repro playground demonstrating the issue https://pl.kotl.in/tC25RSijl You can see that without the `replay + 1`, the late subscriber will only be receiving the completion notification from cache,...