Klemen
Klemen
Continues work started in #483 Changes: - In `contracts/domain/BosonConstants.sol` and `scripts/config/revert-reasons.js` - Added revert reasons EXCHANGE_ALREADY_EXISTS, INVALID_RANGE_LENGTH, TOO_MANY_TO_MINT, OFFER_EXPIRED_OR_VOIDED, OFFER_STILL_VALID and NOTHING_TO_BURN - Moved few revert reasons from "exchange realted"...
Utility script that prints out which contracts changed between two commits. Especially useful for upgrade preparation. Allows comparison of tags/commits/branches (any combination).
Effectively the same as #473 except the latest main was merged into and conflicts were resolved. If this is merged, #473 should be closed without merging.
Goerli is being deprecated and has become very unreliable. Most services are dropping the support for this network and are moving to Sepolia. Version v2.4.0 of protocol should be deployed...
In `escalateDisputeInternal` a `FundsEncumbered` is emitted even if no funds were encumbered (i.e. when DRFee is 0). https://github.com/bosonprotocol/boson-protocol-contracts/blob/be6ff0815e959fcc78377780ae6b06227528dde0/contracts/protocol/bases/DisputeBase.sol#L126 In other parts of the protocol, we emit it only for non-zero...

Currently, only EOA can use metatransactions. However, some users (especially seller admins) could be contracts (multi-sig for example), which might still want to use the same functionality. To support it,...
Method createRoyaltyRecipientAccount is missing the documentation https://github.com/bosonprotocol/boson-protocol-contracts/blob/9ed49d780f04b2f168001f72d6c09f5fc94818b7/contracts/protocol/facets/SellerHandlerFacet.sol#L519 + Move it to the end of the file, since it's internal.
A wallet can control multiple accounts at once if they are of different types (buyer, seller, dispute resolver, agent, royalty recipient). Funds for these accounts are tracked individually, so if...
## BES-01C: Lingering TODO Comments | Type | Severity | Location | | ---- | -------- | -------- | | [Code Style](/appendix/finding-types#code-style) | | [BosonErrors.sol:L9](https://github.com/bosonprotocol/boson-protocol-contracts/blob/b29767e7be7b14ff87e69fb2709b4324956b93df/contracts/domain/BosonErrors.sol#L9), [L25](https://github.com/bosonprotocol/boson-protocol-contracts/blob/b29767e7be7b14ff87e69fb2709b4324956b93df/contracts/domain/BosonErrors.sol#L25), [L27](https://github.com/bosonprotocol/boson-protocol-contracts/blob/b29767e7be7b14ff87e69fb2709b4324956b93df/contracts/domain/BosonErrors.sol#L27), [L31](https://github.com/bosonprotocol/boson-protocol-contracts/blob/b29767e7be7b14ff87e69fb2709b4324956b93df/contracts/domain/BosonErrors.sol#L31), [L40](https://github.com/bosonprotocol/boson-protocol-contracts/blob/b29767e7be7b14ff87e69fb2709b4324956b93df/contracts/domain/BosonErrors.sol#L40), [L234](https://github.com/bosonprotocol/boson-protocol-contracts/blob/b29767e7be7b14ff87e69fb2709b4324956b93df/contracts/domain/BosonErrors.sol#L234),...