zachs18

Results 52 comments of zachs18
trafficstars

Replaced uses of `fn allocator` (which doesn't exist yet) with directly accessing the `alloc` field. No longer blocked on #124980. @rustbot ready

This is still (somewhat) blocked on the duplicate diagnostic issue (#101992). Also, unless the semantics around how generic defaults affect inference are changed (e.g. to allow `String` to default to...

Since this is blocked on some hypothetical successor to https://github.com/rust-lang/rust/issues/27336, I guess it should be marked as `S-blocked`? It's also blocked on the ACP. @rustbot label -S-waiting-on-author +S-blocked +S-waiting-on-ACP

Because of the "defaults-don't-affect-type-inference" issue, `alloc::string::String` currently *must* be a concrete non-generic type (or things like `String::ASSOC_CONST` fail). The latest push moves `String` to `alloc::string::string::String` (where `alloc::string::string` is an unstable...

Still more work to do to to get clippy/tests/etc working with having `String` be a type alias, that I don't have time to do at the moment, so marking this...

(`cargo expand` output on the example given above) ```Rust #![feature(prelude_import)] #[prelude_import] use std::prelude::rust_2021::*; #[macro_use] extern crate std; pub struct Magnitude([u8; 0]); impl ::core::cmp::PartialEq for Magnitude { #[inline] #[must_use] fn eq(&self,...

Opened a PR to allow deriving `ByteEq` and `ByteHash` for types with generics. Note that `ByteEq` and `ByteHash` require the type implement `NoUninit`, which cannot currently be derived for generic...

I would not necessarily be opposed to these, but a few notes: 0. (I assume their failure conditions and semantics would be mostly the same as `cast_ref`/`cast_mut`/`cast_slice`/`cast_slice_mut`? Otherwise I don't...

> there is no (fully "blessed") way to get the length of a general slice pointer on stable. Since Rust 1.75.0, with the stabilization of `wrapping_byte_add` it is possible to...

Wow! Great concept here! My old draft PR #134 was similar but only handled private API and didn't go this in-depth, but could still perhaps be useful to look at....